Title: Colored server names appear messed up
Post by: dash9 on May 20, 2009, 11:01:27 PM
As you can see in the list below, sv_hostname for some servers appears messed up, for example: ^^55Nemesis I mean, I'd expect it to be: ^5Nemesis I was not able to reproduce the problem. Any ideas where is the problem? 213.221.124.82:27960 #0.7.1*THd*Clan-Server 62.75.148.148:27960 Kangs great OA server 87.106.131.203:27960 ^3SBZ ^2OA ^3HEADHUNTERS 91.121.205.135:27965 ^^66ROFL^^55 42|0x2B 071/CTF/XBM 212.227.99.62:27965 ^^22supeR^^55,^^77Tourney 87.244.223.69:27960 nCore.sk0.7.1 #1 GroundFlow CTF 62.121.16.157:27960 ^^11[^^44UK^^11] ^^77meowfest 78.46.148.81:44444 KabaBunka OpenArena 0.8.1 Deathmatch 62.212.66.94:27965 RN|^^33CPM RUNS |Fastest Runs: http://maps.furver.se 87.244.223.69:27961 nCore.sk0.7.1 #2 AirFlow CTF 88.170.246.105:27962 ^^66ROFL^^77 42|0x2C DeFRaG/CPM 62.212.66.94:27980 RN|^^33VANILLA DM |http://sv.furver.se 62.212.66.94:27983 RN|^^22VANILLA CTF |http://sv.furver.se 62.149.210.82:27960 ^2CASTUO ^7SERVER CTF ^2INSTANTGIB - GAMESCLAN.COM 88.170.246.105:27961 ^^66ROFL^^55 42|0x2A 071/CTF/BS 88.86.104.88:27961 Lizzie OA Server 212.227.99.62:27971 ^^33supeR^^55,^^77InstaGib 85.124.64.138:27960 Liscon CPL Server 81.167.229.12:27960 rykroken.net - OA 0.8.1 153.19.64.151:27960 ^^11CK^^33/^^22All Rockets CTF 91.121.121.165:27960 GeezerNET.co.uk - FFA Server 1 88.191.49.48:27960 ^^11=^^33SC^^11= ^^77CTF 85.10.196.198:29602 Virtual Cattleground DUEL 85.14.220.244:27960 ~FG~ fiese-greise.de OA-0.7.0 62.104.169.12:27960 ^7Andis ^3FFA ^2Server 91.121.205.135:27961 ^^66O^^77penarena.tuxfamily.org 80.171.32.253:27960 ^3OA HUNT MOD 62.99.168.1:27960 ^1-^2SKY-FORCE.NET ^1TIROL^4!X^1- 88.160.192.237:27961 ^^66ROFL^^77 CHATROOM 193.227.251.198:27960 Source_OpenArena 84.16.252.227:27960 * * NO CTF MAPS * * | NO QUAD OR INVIS BUT PLENTY ASS KICK | High Scores at http://test.y7.ath.cx 91.121.63.224:27960 ^^66ROFL^^77 Instantgib#3 86.59.34.194:37960 stevens own server 83.254.194.53:27962 RN|^^33VQ3 RUNS 62.212.66.94:27967 RN|^^22WTF CTF |http://sv.furver.se 87.244.223.69:27962 nCore.sk_0.8.1 #1 GroundFlow CTF 95.211.6.2:28000 ^^33GoD^^77|^^11g^^77od-oa.de 89.149.254.44:27961 ^^11[endboss.org]^^22ultramaim 91.121.254.101:27960 ^^44[MMU]^^12Open^^24Arena 62.44.82.241:27960 ^^11Buttonclicker^^22Instagib CTF 87.244.223.69:27966 nCore.sk 0.8.1 #3 Airflow 62.146.213.111:27960 CHEFENTWICKLER!!! OA 0.8.1 DM 212.227.99.62:27975 ^^44supeR^^55,^^77DM 74.86.151.152:27960 The Old Farts Arena 193.33.58.134:65535 Grono.net Private Server 194.97.164.134:27960 Belzerail 193.225.224.199:27968 Isotopes OA server by http://clns.hu 208.85.4.48:27980 ^2E+ FFA : http://OA.GoQuake.com : OA on Steroids 62.212.66.94:27989 RN|^^22 CLANSERVER(PRIVATE) 212.85.158.133:27980 ^^66ROFL^^77 Games.TuxFamily.org 208.97.141.21:27950 LAX 100mbit OA 208.85.4.48:27930 ^2E+ TAG : http://OA.GoQuake.com : OA on Steroids 193.84.20.131:27960 ^^77Evil^^22|^^77Arena 91.121.63.224:27962 ^^66ROFL^^77 All Rockets [CTF] 91.121.205.135:27966 ^^66ROFL^^11 42|0xFF 081/CTF/XBM 87.244.223.69:27963 nCore.sk 0.8.1 #4 GR8 Tourney 75.82.40.68:27960 noname 62.212.66.94:27962 RN|^^11TOURNEY3 |http://sv.furver.se 78.47.72.12:27962 ^^11[ULTRAMAIM.DE]^^22CARNAGE 208.69.150.247:27960 JoinPGN.com - Free For All, CA - Hosted by PGN 212.227.99.62:27976 ^^44supeR^^55,^^77TDM 193.9.30.168:27962 ^2[SOD]Clan Server 91.121.121.165:27962 GeezerNET.co.uk - Private Server 193.9.30.144:27961 [SOD] defrag server (TEST!!!) 64.55.41.214:27960 Ambs OA Server 82.192.78.187:27960 GameServers.net - Instagib Only 24.129.185.90:667 Clubbfg.com <FFA> Open Arena Ver.8.0 207.66.255.52:27970 Digichalk 1 vs 1 89.216.39.244:27960 ^^66Y^^55O^^66K^^55O 173.30.190.58:27840 ^5Dakinis Place ^3OA 0.8.1 85.214.94.41:27960 Tuxclouds OA server 87.118.90.41:27960 ^^77Evil^^22|^^77Clanwars 93.187.178.254:27960 RUS_Stream_OA_server 87.118.90.41:27961 ^^77Evil^^22|^^77Instantgib 137.157.8.200:27960 Testicles OA Server 83.243.137.214:27960 -=Nux=- DM Vampire Server 213.17.241.213:27960 ^1Mafia ^2POLSKA 94.23.46.166:27960 ^^22V^^77a^^11r^^77-1-[clan] 62.75.151.72:27960 Q3Rally Deathmatch Pit 91.121.203.3:27960 The ^^66CHESS BAR ^^77is open 212.227.99.62:27980 ^^66supeR^^55,^^77Defrag 62.212.66.94:27964 RN|^^66CORKSCREW |http://sv.furver.se 95.211.6.2:28001 0001 94.124.145.57:27960 ^2lHl.sk^7 {Open Arena} 78.47.72.12:27974 ^^11[ULTRAMAIM.DE]^^22MEGADETH 174.133.21.74:27960 The Jade Garden 83.254.194.53:27961 RN|^^33VQ3 FREESTYLE 24.129.185.90:666 Clubbfg.com <FFA> Open Arena Ver.8.1 91.121.160.41:27961 charred 91.121.205.135:27960 ^^66O^^77penarena.tuxfamily.org 75.173.23.180:27960 FWOPAH!!! blah 62.193.209.130:27960 ^3Sp^1anishAre^3na^4[GIB]-ABERRATORIO.ES 208.85.4.48:27970 ^2E+ CTF : http://OA.GoQuake.com : OA on Steroids 88.198.12.66:27960 ^0[K^1H^3D^0]^4 #1 OpenArena 94.23.46.166:27965 ^^22V^^77a^^11r^^77-2-[clan] 92.132.88.39:15443 ^^44OOK ^^66DM Server 88.160.192.237:27960 ^^66ROFL^^77 BETA MAPS 212.227.99.62:27961 ^^11supeR^^55,^^77HerosArena 193.9.30.144:27960 [sod]clan server (private) 83.223.64.92:27960 ^1CTF ^7arena.^4linudata^7.de 62.75.151.72:27961 Q3Rally 1.4 Testserver 82.211.202.16:27960 harvester beta server 213.208.134.76:27985 >> multiple paranoia << 91.121.160.41:27960 charred 207.66.255.52:27960 Digichalk 0.8.1 87.244.223.69:27964 nCore.sk 0.8.1 #2 real DeathMatch 62.212.66.94:27966 RN|^^33CPM RUNS 081 |Fastest Runs: http://maps.furver.se 70.32.42.212:27960 ^^55Nemesis 67.214.140.208:27960 ^^22[PL]^^33Capture^^99Flag 221.119.250.198:27980 OA 0.8.1 LemonSoda FFA 72.14.177.208:42914 ^^77/oaN/ (CTF) 70.32.42.214:27960 ^^55/^^77V^^55/ 213.180.43.70:27960 ^^11[^^44C^^77Z^^11] Beta OA Server 85.10.196.198:29600 Virtual Cattleground FFA 173.30.190.58:27860 ^2Dakinis Rail Only ^3OA 0.8.1 ^4Exessive^3plus 91.121.121.165:27961 GeezerNET.co.uk - FFA Server 2 212.227.99.62:27970 ^^33supeR^^55,^^77CTF 83.254.194.53:27960 RN|^^44FreezeRail 67.71.6.199:27960 Galaxy OA server 89.27.212.22:27960 Andy's OpenArena Server 221.119.250.198:27990 OA 0.8.1 LemonSoda CTF 85.25.250.183:27960 ^1|>^7B^1<|^1Bunker #12 Q3Rally 208.85.4.48:27940 ^2E+ TDM : http://OA.GoQuake.com : OA on Steroids 212.227.99.62:27960 ^^11supeR^^55,^^77Airways 144.140.154.67:21000 GameArena Open Arena v0.81 189.30.219.146:27960 OpServices Server - 0.8.1 189.2.93.34:27960 OpServices Server - 0.8.1
Title: Re: Colored server names appear messed up
Post by: Cacatoes on May 21, 2009, 04:13:49 AM
It's intentionnal, admins double evey color character because parsing inside server browser seems to act differently.
Title: Re: Colored server names appear messed up
Post by: dash9 on May 21, 2009, 07:55:16 AM
It's intentionnal, admins double evey color character because parsing inside server browser seems to act differently.
Wow, I did not realize.. so if a server name has a color code, that one is stripped in the server browser. I imagine the original intention was not to show colors in the server browser. This functionality is obviously broken, because colors show up, by using ^^dd instead of ^d. EDIT: Willis said this is an OA bug, because the other ioquake3 games do not have this problem. So if it is intentional (I hope not), it should be documented, otherwise it should be fixed.
Title: Re: Colored server names appear messed up
Post by: sago007 on May 22, 2009, 01:33:01 PM
There appears to be some conflicts in the code. One author has tried to clean the strings while another author has tried to make the server list display colors.
Quake III: Arena tried to prevent it but failed and colors destroyed the serverlist alignment . Enemy Territory on the other hand allowed it.
OpenArena has an improved serverlist alignment but does still use the old clean command.
Title: Re: Colored server names appear messed up
Post by: Cacatoes on May 24, 2009, 09:47:54 AM
I didn't think it was that difficult to parse a color string correctly :P
Title: Re: Colored server names appear messed up
Post by: sago007 on May 24, 2009, 11:12:41 AM
Parsing a string that the user is allowed to change is always likely to contain errors. The fact that Quake 3 does not have a dedicated escape char and few of the default Q_* string functions knows about color codes only makes it harder.
The whole problem has been made more logical in revision 14+in http://code.google.com/p/oax/source/list
Title: Re: Colored server names appear messed up
Post by: dash9 on May 24, 2009, 12:17:46 PM
Parsing a string that the user is allowed to change is always likely to contain errors. The fact that Quake 3 does not have a dedicated escape char and few of the default Q_* string functions knows about color codes only makes it harder.
The whole problem has been made more logical in revision 14+in http://code.google.com/p/oax/source/list
In Q_CleanStr() if the string contains a lot of ^^^^...dddd chars, it could fill the stack of the application. In theory, at least. I don't know how big the string can be.. I would simply declare ^ an illegal character and have only this in the loop: if ( c >= 0x20 && c <= 0x7E && c != Q_COLOR_ESCAPE ) { *d++ = c; } s++; I see normal color codes will be supported for server names. BTW, oax will be used for baseoa in the next OA release?
Title: Re: Colored server names appear messed up
Post by: sago007 on May 24, 2009, 01:15:59 PM
BTW, oax will be used for baseoa in the next OA release?
That is the goal. I tried to make the Q_CleanStr in Qcommon do its intended purpose (It is mainly used by bots to recognize colored names). I have thought about stack growth but my tests suggest that lcc supports tail recursion.
|